build(static_centerline_generator): prefix package and namespace with autoware_ #6817

esteve · 2024-04-15T13:37:09Z

Description

This PR adds the autoware_ prefix to the package and puts headers in the autoware namespace.

Part of:

Prefix packages with autoware_ prefix and keep code in autoware namespace autoware#4569

Tests performed

Ran the tests suite.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

I've confirmed the contribution guidelines.
The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

The PR follows the pull request guidelines.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

mergify · 2024-04-15T13:38:11Z

⚠️ The sha of the head commit of this PR conflicts with #6635. Mergify cannot evaluate rules on this PR. ⚠️

planning/static_centerline_generator/src/static_centerline_generator_node.cpp

planning/static_centerline_generator/src/main.cpp

...e/static_centerline_generator/centerline_source/optimization_trajectory_based_centerline.hpp

...atic_centerline_generator/src/centerline_source/optimization_trajectory_based_centerline.cpp

takayuki5168 · 2024-04-16T15:08:21Z

@esteve
Thank you for the change.

I have one comment.
The package name's change and the refactoring had better be separated. Especially, the package name's change has a lot of code changes and has the potential to have a conflict soon, so the change should be merged as soon as possible.

When you create a new PR for the package name's change, I highly recommend not adding the refactoring change.

esteve · 2024-04-16T15:45:08Z

The package name's change and the refactoring had better be separated. Especially, the package name's change has a lot of code changes and has the potential to have a conflict soon, so the change should be merged as soon as possible.

I used the opportunity to fix the clang-tidy warnings that were causing the CI to fail, instead of ignoring them.

mitsudome-r · 2024-04-18T04:28:26Z

@esteve As we have discussed in the Software WG call, I think it's better to first focus on package name fix first, and you can ignore the clang-tidy issues.

esteve · 2024-04-22T12:59:27Z

@takayuki5168 I've reverted any performance or any other improvements detected by clang-tidy, the CI will now fail because of the clang-tidy check, but now the PR only contains the prefix changes.

takayuki5168

Much easier to review. Thank you!

takayuki5168 · 2024-04-23T02:16:08Z

@esteve
Can you fill in the following blanks in the PR's description?

Tests performed
Effects on system behavior

Signed-off-by: Esteve Fernandez <[email protected]>

…nterline_generator.launch.xml Co-authored-by: M. Fatih Cırıt <[email protected]> Signed-off-by: Esteve Fernandez <[email protected]>

Signed-off-by: Esteve Fernandez <[email protected]>

xmfcx · 2024-05-15T12:29:49Z

planning/autoware_static_centerline_generator/src/static_centerline_generator_node.cpp

@@ -168,7 +169,7 @@ std::vector<TrajectoryPoint> resample_trajectory_points(

 StaticCenterlineGeneratorNode::StaticCenterlineGeneratorNode(
  const rclcpp::NodeOptions & node_options)
-: Node("static_centerline_generator", node_options)
+: Node("autoware_static_centerline_generator", node_options)


Should be static_centerline_generator.

xmfcx · 2024-05-15T12:31:01Z

planning/autoware_static_centerline_generator/src/static_centerline_generator_node.cpp

+    "/planning/autoware_static_centerline_generator/load_map",
    std::bind(
      &StaticCenterlineGeneratorNode::on_load_map, this, std::placeholders::_1,
      std::placeholders::_2),
    rmw_qos_profile_services_default, callback_group_);
  srv_plan_route_ = create_service<PlanRoute>(
-    "/planning/static_centerline_generator/plan_route",
+    "/planning/autoware_static_centerline_generator/plan_route",
    std::bind(
      &StaticCenterlineGeneratorNode::on_plan_route, this, std::placeholders::_1,
      std::placeholders::_2),
    rmw_qos_profile_services_default, callback_group_);
  srv_plan_path_ = create_service<PlanPath>(
-    "/planning/static_centerline_generator/plan_path",
+    "/planning/autoware_static_centerline_generator/plan_path",


Should be without the prefix.

xmfcx · 2024-05-15T12:32:51Z

planning/autoware_static_centerline_generator/rviz/static_centerline_generator.rviz

@@ -130,7 +130,7 @@ Visualization Manager:
        Filter size: 10
        History Policy: Keep Last
        Reliability Policy: Reliable
-        Value: /static_centerline_generator/input_centerline
+        Value: /autoware_static_centerline_generator/input_centerline
